perf: minor optimization of byte opcode function#156
Open
tommyrharper wants to merge 2 commits intorust-ethereum:masterfrom
Open
perf: minor optimization of byte opcode function#156tommyrharper wants to merge 2 commits intorust-ethereum:masterfrom
tommyrharper wants to merge 2 commits intorust-ethereum:masterfrom
Conversation
mattsse
pushed a commit
to mattsse/evm
that referenced
this pull request
Jan 17, 2026
chore: update EvmInternals::new to pub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a minor optimization to the
BYTEevaluator.Essentially we can skip the for loop entirely if
op1 < 32, and we only need to iterate up to 7, not 255.So this brings it down from 256 iterations for each function call to either 0 or 8 iterations depending on the value of
op1.